Print max-in-flight value alongside deployment status [v8] #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
…s table when it is set to non-default value (currently 1) Co-authored-by: Greg Weresch <greg.weresch@broadcom.com>
|
remember to rebase on top of |
|
closing as this has been replaced by #3097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This prints
max-in-flight: <value>after the deployment status, when there is an Active deployment for an app and when max-in-flight is set to a non-default valueWhy Is This PR Valuable?
It provides the user with information/confirmation that they have set a non-default max-in-flight value
Applicable Issues/PRs
this PR is based on #3085 and is therefore blocked on that PR getting merged into
v8+@joaopapereira @weresch